Playground/1brc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Manually compute temperature value instead of using Long.parseLong

Browse Source
This commit is contained in:
Filip Hrisafov 2024-01-03 23:28:03 +01:00 committed by Gunnar Morling
parent f5f3a41045
commit 8c5aaf2db9
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/main/java/dev/morling/onebrc/CalculateAverage_filiphr.java
View File

@ -41,6 +41,7 @@ import java.util.stream.StreamSupport;
* Using big decimal and iterating the buffer once: 0m 20s * Using big decimal and iterating the buffer once: 0m 20s
* Using long parse: 0m 11s * Using long parse: 0m 11s
* Using array hash code for city key: 0m 7.1s * Using array hash code for city key: 0m 7.1s
* Manually compute the value: 0m 6.8s
* <p> * <p>
* Using 21.0.1 Temurin with ShenandoahGC on Macbook (Intel) Pro * Using 21.0.1 Temurin with ShenandoahGC on Macbook (Intel) Pro
* `sdk use java 21.0.1-tem` * `sdk use java 21.0.1-tem`
@ -156,10 +157,6 @@ public class CalculateAverage_filiphr {
Map<Integer, Measurement> measurements = HashMap.newHashMap(415); Map<Integer, Measurement> measurements = HashMap.newHashMap(415);
int limit = bb.limit(); int limit = bb.limit();
byte[] cityBuffer = new byte[128]; byte[] cityBuffer = new byte[128];
char[] charArray = new char[8];
CharBuffer charBuffer = CharBuffer.wrap(charArray);
charBuffer.clear();
charBuffer.position(0);
while (bb.position() < limit) { while (bb.position() < limit) {
int cityBufferIndex = 0; int cityBufferIndex = 0;
@ -177,20 +174,29 @@ public class CalculateAverage_filiphr {
} }
byte lastPositionByte = '\n'; byte lastPositionByte = '\n';
int temperatureBufferIndex = 0; boolean negative = false;
long value = 0;
while (bb.position() < limit) { while (bb.position() < limit) {
byte positionByte = bb.get(); byte positionByte = bb.get();
if (positionByte == '\r' || positionByte == '\n') { if (positionByte == '\r' || positionByte == '\n') {
lastPositionByte = positionByte; lastPositionByte = positionByte;
break; break;
} }
else if (positionByte == '-') {
negative = true;
}
else if (positionByte != '.') { else if (positionByte != '.') {
charArray[temperatureBufferIndex++] = (char) positionByte; // The 0 to 9 characters have an int value of 48 (for 0) to 57 (for 9)
// Therefore, in order to compute the digit we subtract with 48
int digit = positionByte - 48;
// We are computing the value by hand (in order to avoid iterating the index twice)
value = value * 10 + digit;
} }
} }
// Create the temperature if (negative) {
long value = Long.parseLong(charBuffer, 0, temperatureBufferIndex, 10); value = -value;
}
Measurement measurement = measurements.get(cityKey); Measurement measurement = measurements.get(cityKey);
if (measurement == null) { if (measurement == null) {