Playground/1brc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce allocations and heap size (#525)

Browse Source 
* Reduce allocations

* Shrink the heap size

* Calculate hash when reading name  (50-100ms difference)

* no need to reverse bytes

* bump heap size
This commit is contained in:
Roman Musin 2024-01-21 17:01:23 +00:00 committed by GitHub
parent 3e1951379a
commit 7bfc7eaec6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 31 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
calculate_average_roman-r-m.sh
View File

@ -19,7 +19,6 @@ JAVA_OPTS="--enable-preview -XX:+UseTransparentHugePages"
# epsilon GC needs enough memory or it makes things worse # epsilon GC needs enough memory or it makes things worse
# see https://stackoverflow.com/questions/58087596/why-are-repeated-memory-allocations-observed-to-be-slower-using-epsilon-vs-g1 # see https://stackoverflow.com/questions/58087596/why-are-repeated-memory-allocations-observed-to-be-slower-using-epsilon-vs-g1
# 2GB seems to be the sweet spot JAVA_OPTS="$JAVA_OPTS -XX:+UnlockExperimentalVMOptions -XX:-EnableJVMCI -XX:+UseEpsilonGC -Xmx1G -Xms1G -XX:+AlwaysPreTouch"
JAVA_OPTS="$JAVA_OPTS -XX:+UnlockExperimentalVMOptions -XX:-EnableJVMCI -XX:+UseEpsilonGC -Xmx2G -Xms2G -XX:+AlwaysPreTouch"
java $JAVA_OPTS --class-path target/average-1.0.0-SNAPSHOT.jar dev.morling.onebrc.CalculateAverage_roman_r_m java $JAVA_OPTS --class-path target/average-1.0.0-SNAPSHOT.jar dev.morling.onebrc.CalculateAverage_roman_r_m

45
src/main/java/dev/morling/onebrc/CalculateAverage_roman_r_m.java
View File

@ -82,19 +82,30 @@ public class CalculateAverage_roman_r_m {
private void parseName(ByteString station) { private void parseName(ByteString station) {
long start = offset; long start = offset;
long pattern;
long next = UNSAFE.getLong(offset); long next = UNSAFE.getLong(offset);
while ((pattern = applyPattern(next, SEMICOLON_MASK)) == 0) { long pattern = applyPattern(next, SEMICOLON_MASK);
int bytes;
if (pattern != 0) {
bytes = Long.numberOfTrailingZeros(pattern) / 8;
offset += bytes;
long h = Long.reverseBytes(next) >>> (8 * (8 - bytes));
station.hash = (int) (h ^ (h >>> 32));
}
else {
long h = next;
station.hash = (int) (h ^ (h >>> 32));
while (pattern == 0) {
offset += 8; offset += 8;
next = UNSAFE.getLong(offset); next = UNSAFE.getLong(offset);
pattern = applyPattern(next, SEMICOLON_MASK);
} }
int bytes = Long.numberOfTrailingZeros(pattern) / 8; bytes = Long.numberOfTrailingZeros(pattern) / 8;
offset += bytes; offset += bytes;
}
int len = (int) (offset - start); int len = (int) (offset - start);
station.offset = start; station.offset = start;
station.len = len; station.len = len;
station.hash = 0;
station.tail = next & ((1L << (8 * bytes)) - 1); station.tail = next & ((1L << (8 * bytes)) - 1);
offset++; offset++;
@ -215,11 +226,9 @@ public class CalculateAverage_roman_r_m {
this.ms = ms; this.ms = ms;
} }
@Override public String asString(byte[] reusable) {
public String toString() { UNSAFE.copyMemory(null, offset, reusable, Unsafe.ARRAY_BYTE_BASE_OFFSET, len);
var bytes = new byte[len]; return new String(reusable, 0, len);
UNSAFE.copyMemory(null, offset, bytes, Unsafe.ARRAY_BYTE_BASE_OFFSET, len);
return new String(bytes, 0, len);
} }
public ByteString copy() { public ByteString copy() {
@ -243,9 +252,7 @@ public class CalculateAverage_roman_r_m {
if (len != that.len) if (len != that.len)
return false; return false;
int i = 0; for (int i = 0; i + 7 < len; i += 8) {
for (; i + 7 < len; i += 8) {
long l1 = UNSAFE.getLong(offset + i); long l1 = UNSAFE.getLong(offset + i);
long l2 = UNSAFE.getLong(that.offset + i); long l2 = UNSAFE.getLong(that.offset + i);
if (l1 != l2) { if (l1 != l2) {
@ -257,13 +264,14 @@ public class CalculateAverage_roman_r_m {
@Override @Override
public int hashCode() { public int hashCode() {
if (hash == 0) {
long h = UNSAFE.getLong(offset);
h = Long.reverseBytes(h) >>> (8 * Math.max(0, 8 - len));
hash = (int) (h ^ (h >>> 32));
}
return hash; return hash;
} }
@Override
public String toString() {
byte[] buf = new byte[100];
return asString(buf);
}
} }
private static final class ResultRow { private static final class ResultRow {
@ -318,10 +326,11 @@ public class CalculateAverage_roman_r_m {
} }
TreeMap<String, ResultRow> toMap() { TreeMap<String, ResultRow> toMap() {
byte[] buf = new byte[100];
var result = new TreeMap<String, ResultRow>(); var result = new TreeMap<String, ResultRow>();
for (int i = 0; i < SIZE; i++) { for (int i = 0; i < SIZE; i++) {
if (keys[i] != null) { if (keys[i] != null) {
result.put(keys[i].toString(), values[i]); result.put(keys[i].asString(buf), values[i]);
} }
} }
return result; return result;